Boost: Add default URLs for foundation pages #39884

haqadn · 2024-10-23T18:38:05Z

Proposed changes:

If the site has woocommerce, add the woocommerce URLs as default foundation pages
If cornerstone content is set in Yoast, use those in foundation pages

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

None

Testing instructions:

Install woocommerce and setup
Install yoast mark a couple of pages as cornerstone content
Check the foundation pages settings, they should contain those pages as default

github-actions · 2024-10-23T18:39:06Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/boost

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Boost plugin:

Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

dilirity · 2024-10-25T09:29:49Z

@haqadn I switched the base branch to add/foundation-pages. Was previously trunk.

I think a commit is necessary to reset the CI.

haqadn · 2024-10-29T09:38:55Z

@haqadn I switched the base branch to add/foundation-pages. Was previously trunk.

I think a commit is necessary to reset the CI.

I manually re-ran them. Looks like "PR is up to date" won't go away.

dilirity · 2024-10-29T14:22:10Z

I manually re-ran them. Looks like "PR is up to date" won't go away.

Yeah. That's why I mentioned a commit. It seems that there's a bug that goes away if you push after changing the base branch. That helps the CI get unstuck. The merge I did fixed things.

dilirity

Really love the defaults!

Though one thing I found weird. If I clear my list and save, it shows defaults. Then if I go and remove the shop page it automatically disappears from the list.

I think we should be explicit about what the behavior of the foundation pages is, so users don't wonder why that happens.

I made two small fixes.
The first (ca71f08) fixes a function reference (it's not a problem, I just like to be explicit).
The second (ec3945d, ffa1fb6), to prevent the $url array from containing false, because get_permalink can return that.

Anyway, outside of that, I think this is shippable!

dilirity · 2024-10-29T14:26:19Z

projects/plugins/boost/app/lib/Foundation_Pages.php

+	public function register_ds_stores() {
+		$schema = Schema::as_array( Schema::as_string() )->fallback( self::default_pages() );
+		jetpack_boost_register_option( 'foundation_pages_list', $schema, new Foundation_Pages_Entry( 'foundation_pages_list' ) );
+		jetpack_boost_register_readonly_option( 'foundation_pages_properties', array( $this, 'get_properties' ) );


Nice! I really like seeing this here.

dilirity · 2024-10-29T14:26:51Z

projects/plugins/boost/app/lib/Foundation_Pages.php

+		$yoast_cornerstone_content = get_posts(
+			array(
+				'meta_key'       => '_yoast_wpseo_is_cornerstone',
+				'meta_value'     => '1',
+				'post_type'      => 'any',
+				'posts_per_page' => $max_pages,
+			)
+		);


Checked if Yoast has a way to do this for us, but sadly it doesn't ):

* Add a dummy foundation pages class * changelog * Boost: Implement partial cloud CSS regeneration (#39833) * Improve the jetpack_boost_critical_css_urls filter * Add a filter for the source providers * Remove front_page as provider when foundation page is setup * Add context support for core providers * Implement partial regeneration * Regenerate blog page if blog page itself is updated * Cast core page ids to int * Boost: Add foundation pages UI (#39832) * Get foundation pages from datasync * Feature flag the foundation pages UI * Add feature flags to foundation pages class * Boost: Add foundation provider (#39842) Co-authored-by: Peter Petrov <[email protected]> * Measure the first foundation page for speed score * Add note about blog url always included in foundation pages * Fix syntax * Update foundation pages description text * Boost: Add "Foundation Page" state in WP's page listing scree (#39878) * Add indication if a page is a foundation page in WPs page listing * add changelog * Update page speed tooltip text * Boost: Add notice when updating a page from the foundation pages list (#39876) * Update foundation pages description text * Update UI to show a critical css notice after updating a foundation page * add changelog * Fix static analysis * Update notice error * Fix missing blog page from source providers * Boost: Prompt c.css regen when updating foundation pages list (#39881) * Suggest regeneration when foundation pages list was updated * add changelog * Fix updating regenerate reason without making sure the value got updated * Refetch regeneration reason instead of setting it after updating list * Boost: Update foundation page list instructions (#39885) * Boost: Add default URLs for foundation pages (#39884) Co-authored-by: Peter Petrov <[email protected]> * Move beta element to its own component * Update foundation pages UI to include experiment tag * Update foundation pages description to include upgrade link * Replace foundation with cornerstone * Remove feature flag for cornerstone pages * Fix cornerstone page URLs not starting with a slash * Fix calling undefined method * Fix cornerstone pages UI not showing * Change wording * Update cornerstone description --------- Co-authored-by: Adnan Haque <[email protected]> Co-authored-by: Adnan Haque <[email protected]>

Add default values

66c11b3

haqadn added the [Status] Needs Team Review label Oct 23, 2024

haqadn requested a review from a team October 23, 2024 18:38

haqadn self-assigned this Oct 23, 2024

github-actions bot added [Boost Feature] Cloud CSS [Plugin] Boost A feature to speed up the site and improve performance. Admin Page React-powered dashboard under the Jetpack menu labels Oct 23, 2024

dilirity changed the base branch from trunk to add/foundation-pages October 25, 2024 09:29

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 25, 2024

haqadn removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 29, 2024

Merge branch 'add/foundation-pages' into fp/default-urls

7aaf631

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 29, 2024

dilirity removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 29, 2024

dilirity added 2 commits October 29, 2024 16:22

Make sure URLs are valid before adding them to the list

ec3945d

Use global function reference instead of namespaced one

ca71f08

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 29, 2024

dilirity approved these changes Oct 29, 2024

View reviewed changes

dilirity merged commit d9f2370 into add/foundation-pages Oct 29, 2024
52 of 54 checks passed

dilirity deleted the fp/default-urls branch October 29, 2024 14:31

github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Boost: Add default URLs for foundation pages #39884

Boost: Add default URLs for foundation pages #39884

haqadn commented Oct 23, 2024

github-actions bot commented Oct 23, 2024 •

edited

Loading

dilirity commented Oct 25, 2024

haqadn commented Oct 29, 2024

dilirity commented Oct 29, 2024

dilirity left a comment •

edited

Loading

dilirity Oct 29, 2024

dilirity Oct 29, 2024

Boost: Add default URLs for foundation pages #39884

Boost: Add default URLs for foundation pages #39884

Conversation

haqadn commented Oct 23, 2024

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Oct 23, 2024 • edited Loading

dilirity commented Oct 25, 2024

haqadn commented Oct 29, 2024

dilirity commented Oct 29, 2024

dilirity left a comment • edited Loading

Choose a reason for hiding this comment

dilirity Oct 29, 2024

Choose a reason for hiding this comment

dilirity Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 23, 2024 •

edited

Loading

dilirity left a comment •

edited

Loading